fix: handle cancelled notifications for request id zero#2116
Open
nacim-coder wants to merge 1 commit into
Open
fix: handle cancelled notifications for request id zero#2116nacim-coder wants to merge 1 commit into
nacim-coder wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: a41f7c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
fix: handle cancelled notifications for request id zero
Linked issue
Closes #2115
Summary
requestIdas missing when handlingnotifications/cancelled0so the first request from a protocol instance can be cancelled0@modelcontextprotocol/coreValidation
corepack pnpm install --frozen-lockfilecorepack pnpm --filter @modelcontextprotocol/core test -- --run packages/core/test/shared/protocol.test.tsResult: core test suite passed, 21 files / 553 tests
corepack pnpm --filter @modelcontextprotocol/core typecheckcorepack pnpm --filter @modelcontextprotocol/core lintcorepack pnpm exec prettier --check .changeset/fuzzy-birds-cancel.mdNotes
No behavior changes for other request IDs. This only avoids treating numeric ID
0as falsy/missing.